Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update execute_script method #894

Merged
merged 5 commits into from
Sep 5, 2024
Merged

FIX: Update execute_script method #894

merged 5 commits into from
Sep 5, 2024

Conversation

dipinknair
Copy link
Collaborator

  • Return value of executed script
  • add tests

@dipinknair dipinknair requested a review from koubaa September 5, 2024 15:07
@github-actions github-actions bot added the bug Something isn't working label Sep 5, 2024
@dipinknair dipinknair changed the title Feat: Update execute_script method FIX: Update execute_script method Sep 5, 2024
@dipinknair dipinknair marked this pull request as ready for review September 5, 2024 15:14
@dipinknair dipinknair requested a review from a team as a code owner September 5, 2024 15:14
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.66%. Comparing base (cf3b0c5) to head (3c4a705).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
+ Coverage   79.86%   80.66%   +0.80%     
==========================================
  Files          33       33              
  Lines        2155     2162       +7     
==========================================
+ Hits         1721     1744      +23     
+ Misses        434      418      -16     

@dipinknair dipinknair merged commit 32344ff into main Sep 5, 2024
56 of 57 checks passed
@dipinknair dipinknair deleted the fix/execute_script branch September 5, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants